PSADT v4.0.6 exit code problem

[mjr4077au]

I’m trying to work out whether you’re agreeing with me or having a go at me . Let’s try and break it down.

@SeriousQuestion

Why are you talking about “SupressReboot” ??? I am talking about the very CORE function of any script language, program or app, namely proper handling of EXIT CODES.

Regrettably, our toolkit even in the v3 days has had an option called -AllowRebootPassThru, whereby in its default state, a nominated reboot code does not get returned; instead returning 0. We don’t believe this is the right approach anymore and seek to change it, however people may be relying on that behaviour, rightly or wrongly, hence the suggestion of an opposing switch to replace it which does the opposite.

@SeriousQuestion

If MECM or anything else doesn’t handle or “accept” anything other than 0 as a success, then that is a failure or lack of feature on MECM’s part. It is NOT something you should try and solve, especially in the way of ALWAYS returning exit code 0.

I believe we’re in complete agreement here, hence why we’re trying to right the wrongs of the past for the benefit of not just yourself, but the wider community.

@SeriousQuestion

This literally means the toolkit is useless, since I can’t even know if the installation failed.

Far from it. By virtue of the name, the -AllowRebootPassThru switch only supresses the return of an exit code that’d tell MECM, Intune, or other software that an app deployment requires a reboot. A failing exit code will always be returned when an error occurs, either the app installer’s own exit code or one of our generic ones in the event of a script typo, etc.

@SeriousQuestion

I will say it again, v4 is no-go for anyone that needs to properly know an exit code. Did something go wrong, does the device actually need a reboot, did the installation generate a custom exit code.

I believe you’ve got a huge misunderstanding about what’s being talked about here and as such, I’d refer to you to the previous quote reply in this post I’m writing to you now. I will say it again, v4, like v3, will return an error code at all times when a deployment fails unless you as the packager go out of your way to suppress. The only thing v4 suppresses is the same thing that v3 suppresses by default, reboot exit codes.

@SeriousQuestion

None of this can be gleaned from the current implementation of v4.

There shouldn’t be anything in-particular to glean as the behaviour in this regard is 1:1 with v3 and it was very deliberate to make v4 maintain the core of what makes PSAppDeployToolkit the solution everyone’s come to know and love. We absolutely welcome documentation suggestions or improvements from the comunity and want to make sure you’ve got the information necessary to feel empowered with your deployments. On the initial release of v4, some of our documentation did not meet our own standards which we apologise for. I can only offer excuses, however the refactoring that’s gone into making v4 was no small undertaking and in trying to deliver a first class product among sacrificing personal time with our family, friends, and loved ones to deliver the product for free, the quality of documentation did slip in that process.

@SeriousQuestion

It baffles me how one can do this at all if I am being honest.

I’m unsure whether you’ve used v4 yet, however you yourself can download our latest template, add a line akin to Start-ADTProcess -FilePath cmd.exe -ArgumentList '/c "exit 1234"' and observe your deployment will fail and exit out with an exit code of 1234. That truly is package management 101 and nothing’s slipped there.